please remove logger from the args, we don't use logr as argument to functions, we use contextual logging.
for example

log.FromContext(ctx).V(logutil.TRACE).Info(....)

see for example here:

I asked him to remove that, in the streaming case the high volume of instantiations of the logger will cause allocation/gc pressure. Luke mentioned this as an optimization during flow control benchmarking, and i think the same applies here b/c there will be multiple streaming calls per request.

Does log.FromContext(ctx).V(logutil.TRACE).Info(....) actually make another logger? I would think it takes the logger "from the context" given ctx has a logger. Does it actually allocate more memory? I would think that pretty inefficient.

From the FromContext() in go-logr package:

// FromContext returns a Logger from ctx or an error if no Logger is found.

@nirrozenbaum @kfswain What is the desired state for this? I can revert it back or keep the changes

I don't think it makes another logger.
that wouldn't make sense.

the desired state (at least in my opinion) is to remove logger from the args and use contextual logging if/when necessary.
we don't pass around logger in any part of the code. we pass ctx (which includes inside it the logger).

Okay, keeping logger in parameters. I don't have a strong opinion on this beyond we probably shouldn't create a logger for every chunk streamed.

There's a confusion here.
@kfswain the call Logger.WithValues creates a new instance of the logger (with some key value pairs attached to it). we create a logger only ONCE somewhere up in the handling chain and store it inside the context using log.IntoContext(ctx, logger). for example here:

then, in all other functions, we call log.FromContext(ctx). This call does NOT create a new logger. it retrieves the stored logger from the context. more information here:
https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/log#pkg-functions

The best practice in contextual logging is to create logger once and store it into the context, and retrieve it from context in the various places.

Ah, yeah sorry, mixed messaging here, the initial implementation had the WithValues.

I'm slightly confused here, the FromContext in log.go always calls log.WithValues(keysAndValues...), it's the only way the function can return. Should I keep this logging regardless?

I was checking now again. I see your point.
I’m still not sure about that, but anyway this looks to me like a system wide issue cause we’re using contextual logging in all places.

I suggest to move forward with current PR using Log.FromContext, open a dedicated issue to check about this issue, and if we decide to change, we need to update everywhere, not only in this function.

let me know if it makes sense.